Add support for deb822 apt sources format#260
Open
deosrc wants to merge 2 commits into
Open
Conversation
|
|
deosrc
marked this pull request as ready for review
February 3, 2025 19:51
|
#264 is working on the same topic. There are still a few quirks if migrating from one to the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The decision on format to use is determined by the
visual_studio_code_use_deb822_formatvariable. I'm not aware of a way to auto-detect the preferred format.I've tried to keep this consistent with the style of other areas, so the forking logic (i.e. decision of deb822 or oneline format) uses include_tasks to "skipped" tasks. This means the original apt source setup needed extracting to a separate file.
Rather than re-use the apt key setup, I've jsut used the built-in functionality of the
deb822_repositorytask. The only difference I believe would be the filename.I'm not sure how to write molecule tests so haven't been able to add those, but have tested using check mode for both, and run mode for deb822.
Resolves #259