Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size issue in SpStabilizerOfIsotropicSubspace #128

Merged
merged 5 commits into from
Mar 20, 2025

Conversation

TristanPfersdorff
Copy link
Collaborator

@TristanPfersdorff TristanPfersdorff commented Jul 7, 2024

Pretty much everything I mentioned in here, tackling #127.

@TristanPfersdorff TristanPfersdorff changed the title Fix #127 Fix size issue in SpStabilizerOfIsotropicSubspace Jul 7, 2024
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks but the base CI is badly broken. Ideally this is fixed first and then we merge this PR when its CI passes... I'll see what I can do

@fingolfin fingolfin closed this Jan 21, 2025
@fingolfin fingolfin reopened this Jan 21, 2025
@fingolfin fingolfin closed this Jan 22, 2025
@fingolfin fingolfin reopened this Jan 22, 2025
@fingolfin fingolfin closed this Mar 11, 2025
@fingolfin fingolfin reopened this Mar 11, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (f569bac) to head (9a534da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          14       14           
  Lines        4682     4684    +2     
=======================================
+ Hits         4425     4427    +2     
  Misses        257      257           
Files with missing lines Coverage Δ
gap/ReducibleMatrixGroups.gi 98.75% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fingolfin fingolfin merged commit 1375b8b into gap-packages:main Mar 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants