Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default StorageClass name from default-class to default #480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ialidzhikov
Copy link
Member

How to categorize this PR?

/kind enhancement
/platform vsphere

What this PR does / why we need it:
Similar to gardener/gardener#8565. See the PR description of gardener/gardener#8565 for the motivation of this change.

The StorageClass is mainly used during PVC provisioning. I also tested and verified that a PVC with a deleted StorageClass can be successfully attached/detached, mounted/unmounted and deleted.
However, the PVC resize operation requires the StorageClass to be existing. Trying to send an update request that increases the size of the PVC fails with:

error: persistentvolumeclaims "claim" could not be patched: persistentvolumeclaims "claim" is forbidden: only dynamically provisioned pvc can be resized and the storageclass that provisions the pvc must support resize

However, I think that this should be acceptable because:

  • provider-vsphere is not yet productively used
  • if needed, the issue can be mitigated by copying the StorageClass with name default and created one with name default-class

Currently the default StorageClass of all provider extensions is named default:

Which issue(s) this PR fixes:
Related to gardener/gardener-extension-registry-cache#3

Special notes for your reviewer:
N/A

Release note:

The default StorageClass is renamed from `default-class` to `default`. PVC referring to the `default-class` should continue to successfully attach/detach,  mount/unmount and delete. However, only the resize operation will be affected. If resize is needed for such PVC, then a StorageClass with name `default-class` (copy of the `default` StorageClass) can be temporary created.

@ialidzhikov ialidzhikov requested review from a team as code owners November 2, 2023 10:28
@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else kind/enhancement Enhancement, improvement, extension platform/vsphere VMware vSphere platform/infrastructure needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 2, 2023
@ialidzhikov ialidzhikov force-pushed the enh/default-storage-class-name branch from 076a442 to 40054c5 Compare November 2, 2023 11:38
@ialidzhikov ialidzhikov changed the title Change the default StorageClass name from default to default-class Change the default StorageClass name from default-class to default Nov 2, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 2, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 2, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension lifecycle/stale Nobody worked on this for 6 months (will further age) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else platform/vsphere VMware vSphere platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants