feat: Clone existing repository config - #907
Conversation
|
@garethgeorge The PRs I've put up should be ready for review if you have the time :) |
|
Hi -- thanks for the interest in contributing, appreciate the PR! I want to start out with this is definitely a long standing issue and something I'd like to address, but I'm a bit opinionated about the right way to solve this. I'm hesitant to introduce a new button on the submit rows of the repo / plan UIs since they'll become cluttered, duplicating plans or copying configuration is only something we think about when making a new plan or repo. My thinking for a good solution to this is that it should be something like an optional dropdown when creating a new plan or repo (from an empty state) which allows the user to copy settings from an existing plan / repo. wdyt? |
|
Oh that's a good idea - I'll look at implementing this both on this PR and on the plan PR :) |
|
It's a more common UI trope to visit the 'one' you want to duplicate, to duplicate it Of course 'Add Plan' | 'Add Plan from Existing' might be OK, but you suggest a dropdown or an arrow, that is now way more involved or prominent in the UI flow than a 'Duplicate' button And if the 'Add Plan' blank window suggests to pull in config from another plan, then you have to have UI to permit selection of which plan, ... that's extra steps... I think simplest most intuitive option wins out here...
This can be addressed here by just using the button label "Duplicate" instead of the PR's suggestion "Clone Repository Config" which unnecessarily repeats the modal context 'repository config', among neighbouring buttons which do not do this (e.g. 'Delete' not 'Delete Repository') There are not many other possible buttons to add here, either, so the clutter isn't already happening nor likely to |
1a75a0a to
aeade74
Compare



Added a button to clone existing repository configs. This preserves everything about the repository config you're trying to clone, while all fields remain editable, allowing you to use the same settings for different repositories.