Make it compatible with Node.js 4 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert it to make it compatible with older version of Node.js
Object destructuring assignment like "const { version, name } = require('./package.json');" is not supported in Node.js 4 so this change makes it compatible with older Node.
garthk
requested changes
May 29, 2017
There was a problem hiding this comment.
Now we're not destructuring, the extra noise near the imports bothers me more than I imaine dereferencing through the package name will. Could you try const pkg = require('./package.json') up the top, pkg.name and pkg.version further down, and similar changes for path and fs?
If it looks awful, no need to commit, just let me know. Or, if you'd rather I do the work, let me know and I'll merge and clean up.
I'm not sure transpileModule and readConfigFile are good names for the results of the ts.transpileModule and readConfigFile calls. Try results or output, perhaps? (I'm having a low imagination morning; I bet you can do better.)
Very close. Thanks!
|
Is it better now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote the restructuring. Should be good now.