TEST 7702 PR for greptile review bot #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Container verification step in release process automated with the container verify GitHub workflow. New workflow is triggered at the end of the release workflow which will check the release container images starts successfully. Verification test only checks container starts and reach the Ethereum main loop Signed-off-by: Chaminda Divitotawela <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Fix some reasons for chain download halts when syncing Signed-off-by: [email protected] <[email protected]> Signed-off-by: Stefan Pingel <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Check and test for the unused container rule, and only returncontract targets can have truncated data rule. Also test the other subcontainer rules in unit tests. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
…#7247) Signed-off-by: Gabriel-Trintinalia <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
…transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
…to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <[email protected]>
…ting accounts as well Signed-off-by: Daniel Lehrner <[email protected]>
…only available in the prague hard fork Signed-off-by: Daniel Lehrner <[email protected]>
…yet exist Signed-off-by: Daniel Lehrner <[email protected]>
…rty (hyperledger#7222) * Add build version option to prefix git hash with custom version property * Refactor to make appending the git hash a boolean property. Include a commented-out example of how to use the properties in the gradle file Signed-off-by: Matthew Whitehead <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
…yperledger#7221) Signed-off-by: Jason Frame <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Ties <[email protected]> Co-authored-by: Matt Nelson <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* Add option for LUKSO network Signed-off-by: Wolmin <[email protected]> * Add tests for LUKSO Signed-off-by: Wolmin <[email protected]> * Apply spotless Signed-off-by: Wolmin <[email protected]> * Add changelog entry Signed-off-by: Wolmin <[email protected]> * Fix duplicate func Signed-off-by: Wolmin <[email protected]> * Fix changelog Signed-off-by: Wolmin <[email protected]> * Add bootnodes to genesis Signed-off-by: Wolmin <[email protected]> --------- Signed-off-by: Wolmin <[email protected]> Signed-off-by: Wolmin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
…erledger#7245) Make the max code size and max initcode size a part of the EVM configuration. As part of the change we need to move the tasks CodeFactory once handled as a static class and move it into the EVM. This has a nice follow on effect that we don't need to pass in max EOF versions or max code sizes anymore. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* fix the synchronizer usage Signed-off-by: Leni <[email protected]> * fix Identifier usage Signed-off-by: Leni <[email protected]> --------- Signed-off-by: Leni <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Justin Florentine <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Add Genesis ("CancunEOFTime") and reference test ("CancunEOF") support
for a temporary Cancun+EOF fork, in anticipation of potential devnets.
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
…er to understand Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Jason Frame <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Increment private nonce even if transaction failed Signed-off-by: George Tebrean <[email protected]> Signed-off-by: [email protected] <[email protected]> Co-authored-by: [email protected] <[email protected]> Co-authored-by: Stefan Pingel <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* feat: --profile can load external profiles * fix external profile name method * fix ProfilesCompletionCandidate * test: Add unit tests * changelog: Update changelog * test: Fix TomlConfigurationDefaultProviderTest * test: Fix BesuCommandTest --------- Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Documentation has been moved to GitHub pages and no longer use readthedocs. Updated the README status badge for docs with correct link Signed-off-by: Chaminda Divitotawela <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* typos Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
…t instances of the world updater, renamed some classes Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
* Add evmtool block-test subcommand Add an evmtool subcommand that will run non-hive blockchain tests. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* make snap tasks switching Signed-off-by: [email protected] <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
…edger#7309) * 6612: Remove deprecated sync modes and related helper methods Signed-off-by: Matilda-Clerke <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Fix a number of issues found in reference tests and evmone tests. - Be tolerant of more nulls in json - Support ContainerKind in reference tests - re-order EXTCALL oeprands - correct return value for REVERT in EXT*CALL - re-order EOFCREATE code validation Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: garyschulte <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* use gnark-crypto for bls precompiles Signed-off-by: garyschulte <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <[email protected]> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <[email protected]> * 6612: Update changelog with removal of deprecated sync modes Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Matilda Clerke <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Check for OOG earlier in DataCopy. Add unit tests to cover operation branches. Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* disable flaky test Signed-off-by: Sally MacFarlane <[email protected]> * disable flaky test Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* Update parameterized unit tests so the enumerate with --dry-run * Update the prague-withdrawal.json unit test to handle current code Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
… code Signed-off-by: Daniel Lehrner <[email protected]>
…ance nor code" This reverts commit 9c9121a. Signed-off-by: Daniel Lehrner <[email protected]>
* removed PKI backed QBFT Signed-off-by: Sally MacFarlane <[email protected]> * changelog Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
* add request type for consolidations, encoder, decoder and tests * added raw tx for consolidation * add consolidation reqs to EngineGetPayloadResultV4 * set storage slot value to 0 initially and value for tx * updates plugin api Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]> --------- Signed-off-by: Sally MacFarlane <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
… the transaction object (hyperledger#7323) * fix: Use Builder for JsonCallParameter * changelog * add additional unit tests * fix: Update builder to withGas to match the json eth_call --------- Signed-off-by: Usman Saleem <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: Daniel Lehrner <[email protected]>
… isn't set Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
Signed-off-by: Daniel Lehrner <[email protected]>
… nonces Signed-off-by: Daniel Lehrner <[email protected]>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
PragueAcceptanceTestService.javafor testing Prague engine JSON-RPC calls. - Introduced
SetCodeTransactionAcceptanceTest.javafor SetCode transaction type. - Updated
Transaction.javaandTransactionType.javato support EIP-7702 transactions. - Added
SetCodeTransactionEncoderandSetCodeTransactionDecoderfor encoding/decoding. - Modified
MainnetTransactionProcessor.javaandMainnetTransactionValidator.javato handle new transaction types and authorization lists.
29 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings
| final Optional<String> validationError) { | ||
| @JsonProperty("status") final EngineStatus status, | ||
| @JsonProperty("latestValidHash") final Hash latestValidHash, | ||
| @JsonProperty("errorMessage") final Optional<String> validationError) { |
There was a problem hiding this comment.
Style: Consider renaming the field validationError to errorMessage for consistency.
There was a problem hiding this comment.
too opinionated. validationError is more descriptive in this context
|
|
||
| @Override | ||
| public Optional<Long> nonce() { | ||
| return nonces.size() == 1 ? Optional.of(nonces.getFirst()) : Optional.empty(); |
There was a problem hiding this comment.
Spelling: List.getFirst() is not a valid method. Use List.get(0) instead.
There was a problem hiding this comment.
this is a java 21 method
Comment on lines
+93
to
+94
| if (!input.nextIsList()) { | ||
| throw new IllegalArgumentException("Optional nonce must be an list, but isn't"); |
There was a problem hiding this comment.
Spelling: Potential typo: 'an list' should be 'a list'.
Comment on lines
+379
to
+380
| // TODO 7702 | ||
| case SET_CODE -> null; |
There was a problem hiding this comment.
Logic: The SET_CODE transaction type is currently returning null. Ensure this is implemented before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicates #7237 here in order to use the greptile review bot
.