Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean dockerfiles #18

Closed
wants to merge 4 commits into from
Closed

Clean dockerfiles #18

wants to merge 4 commits into from

Conversation

aslafy-z
Copy link
Contributor

  • Rebase on nginx:1-alpine
  • Delete deprecated maintainer fields
  • Delete bash deps as it's not needed
  • Use COPY instead of ADD
  • Lint shellscript

@@ -1,11 +1,7 @@
FROM alpine:edge
MAINTAINER José Moreira <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KyleAMathews @DSchau can we create an alias/group email for the gatsby's maintainers so we can expose it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also have to go in #19

@aslafy-z
Copy link
Contributor Author

@cusspvz
Copy link
Contributor

cusspvz commented Nov 20, 2018

For reference: https://docs.docker.com/engine/reference/builder/#maintainer-deprecated

I knew, but thanks for bringing that up. I just find useful to have a centralized maintainer's email instead of placing our own ones there.

@aslafy-z
Copy link
Contributor Author

@cusspvz sure, I shared it just to point out the use of LABEL maintainer=".." instead of the MAINTAINER instruction

@aslafy-z aslafy-z closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants