chore(docs): Recipes cleanup & Fonts guides #36622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LekoArts
added
the
type: documentation
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
tyhopp
previously approved these changes
Sep 16, 2022
wardpeet
reviewed
Sep 16, 2022
tyhopp
approved these changes
Sep 16, 2022
wardpeet
reviewed
Sep 16, 2022
|
|
||
| ```shell | ||
| yarn add gatsby-plugin-web-font-loader | ||
| npm install gatsby-omni-font-loader react-helmet |
There was a problem hiding this comment.
does font-loader use react-helmet? why do we have to install it?
There was a problem hiding this comment.
Yes, it uses react-helmet for now: codeAdrian/gatsby-omni-font-loader#32
I still chose it though as it's the best webfont loader plugin for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the two last remaining "Recipes" and changes any links to them. I saw that the updated links went to two fonts guides and they both also needed an update. So did that.
Also updated a link inside the "Porting HTML to Gatsby" guide and that also needed an update.
Rendered views:
Related Issues
Redirects PR will follow