NavSat::ToElement() method #1585
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Derbasov <[email protected]>
ntfshard
commented
Sep 2, 2025
Comment on lines
+138
to
+139
| /// Note that parameter passing functionality is not captured with this | ||
| /// function. |
There was a problem hiding this comment.
I copied this text from similar method of other class (at least it consistent)
Comment on lines
+201
to
+203
| const auto defaultNoise = sdf::Noise(); | ||
|
|
||
| if (this->dataPtr->horizontalPositionNoise != defaultNoise) |
There was a problem hiding this comment.
main idea of this checks is to make output as small as possible
|
Have you seen #1538? |
No UPD: I tried to use python bindings to generate sdf files and got error msg, which bring me to missing implementation. Now I see this PR is duplicates implementation of already opened PR |
|
What would you suggest to do in this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
sdf::NavSatdidn't have aToElement()method which prevent to convert sensor-specific information back to sdf format.This PR include such changes:
sdf::NavSat::ToElement()methodSensor::ToElement()This PR was developed on top of sdf15 and retargeted to sdf16 due to sdf16 do not have dev packages.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.