Skip to content

Implement --background-color #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 2, 2025
Merged

Implement --background-color #1508

merged 14 commits into from
May 2, 2025

Conversation

ISSOtm
Copy link
Member

@ISSOtm ISSOtm commented Sep 18, 2024

To do:

  • Allow transparent as a color
  • Allow +color (e.g. +#f0f or +transparent) to not warn when the background color is used within kept tiles (not necessary for the initial feature)
  • Update the man page
  • Add tests

Fixes #1484

@ISSOtm ISSOtm requested a review from Rangi42 September 18, 2024 16:59
@Rangi42 Rangi42 added this to the v0.9.0 milestone Oct 2, 2024
@Rangi42 Rangi42 added enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX labels Oct 3, 2024
@Rangi42 Rangi42 force-pushed the background branch 3 times, most recently from 1a2c621 to 9bdf65d Compare December 2, 2024 22:49
@Rangi42 Rangi42 changed the title Implement --background Implement --background-color Dec 2, 2024
TODO: document the behaviour
@Rangi42 Rangi42 removed this from the v0.9.0 milestone Dec 15, 2024
@Rangi42 Rangi42 assigned Rangi42 and unassigned ISSOtm Jan 4, 2025
@Rangi42 Rangi42 added this to the 0.9.2 milestone Jan 17, 2025
@Rangi42 Rangi42 removed their assignment Jan 18, 2025
@Rangi42 Rangi42 marked this pull request as ready for review May 1, 2025 01:35
Copy link
Member Author

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, the logic seems good to me, so I have only a few nitpicks. Thank you for finishing my half-done work :)

@Rangi42 Rangi42 merged commit 8cf6c54 into gbdev:master May 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Typically new features; lesser priority than bugs rgbgfx This affects RGBGFX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Specify a color to skip tiles which are entirely that color
3 participants