Added ReadBinary and WriteBinary

[RolandHughes]

Hopefully this goes through okay. I needed binary for my embedded systems project. Just thieved your Read() Write() and changed to be a std::vector<uint8_t>. It appears there were some minor spacing things that either Artistic Style or my editor must have tweaked.

Oh, I'm set up to use spaces. It looks like you were using actual tabs. You may or may not want to clean that up.

Thanks for parking this library out here and hopefully this change gets in.

[gbmhunter]

Hi @RolandHughes thanks for the improvements! Definitely merging this in :-). Good point about the existing tabs, I will try and clean that up at some point (I agree, spaces are much better).

[RolandHughes]

.astylerc #  .astylerc # #  Style code according to these switches # --style=allman --indent=spaces=4 --indent-switches # #    Insert space padding on the inside of parenthesis only # --pad-paren-in # #    Add braces around one line blocks # --add-braces # #    place the * or & up against the name when declaring # --align-pointer=name # #    Keep return type and method declaration on same line # --attach-return-type # #    Do not let source lines go beyond this many  characters # --max-code-length=130 --break-blocks --convert-tabs --break-one-line-headers --pad-header --break-blocks

On 12/2/21 3:47 PM, Geoffrey Hunter wrote: Hi @RolandHughes <https://github.com/RolandHughes> thanks for the improvements! Definitely merging this in :-). Good point about the existing tabs, I will try and clean that up at some point (I agree, spaces are much better). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOLYVCN5GLX3IN46AXGCULUO7SN5ANCNFSM5JCZ5FUA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Roland Hughes, President Logikal Solutions (630)-205-1593 http://www.theminimumyouneedtoknow.com http://www.infiniteexposure.net http://www.johnsmith-book.com http://www.logikalblog.com http://www.interestingauthors.com/blog

[RolandHughes]

I might have some other stuff later. Depends on free time and needs of current project. It would be nice if one could have two ring buffers, one for writing and one for reading. Off in its own little thread for each operation the serial port code could just be reading bytes and stuffing them into the ring buffer. A set of ReadPacket() methods could then just look at the ring buffer for 1. matching start & stop patter 2. a start pattern and fixed number of bytes etc. GreenLeaf CommLib used to have this back in the days of DOS when I did a lot of serial work. Just idle thoughts. Roland

On 12/2/21 3:47 PM, Geoffrey Hunter wrote: Hi @RolandHughes <https://github.com/RolandHughes> thanks for the improvements! Definitely merging this in :-). Good point about the existing tabs, I will try and clean that up at some point (I agree, spaces are much better). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOLYVCN5GLX3IN46AXGCULUO7SN5ANCNFSM5JCZ5FUA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Roland Hughes, President Logikal Solutions (630)-205-1593 http://www.theminimumyouneedtoknow.com http://www.infiniteexposure.net http://www.johnsmith-book.com http://www.logikalblog.com http://www.interestingauthors.com/blog