adjoin function for Traversals#187
Open
MoritzR wants to merge 3 commits into
Open
Conversation
This is mostly a translation from adjoin from the haskell lens library: https://hackage.haskell.org/package/lens-5.2/docs/Control-Lens-Unsound.html#v:adjoin TraversableHomogeneousTuple was added as a way to safely traverse the tuple type that `lensProduct` produces. An alternative way should be to use the array Traversable, but that requires casting in order for typescript to accept that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
adjoinfunction for Traversals, that combines two Traversals into one.I could only do that by more or less translating the version from the haskell lens library.
For this reason the
partsOfandproductfunctions also come with it.I was not sure how to best traverse the tuple type returned by
product. I added a newTraversableinstance for thereadonly [A, A]type, though it doesn't look like that's the correct way to build that traverse function. Let me know what a better approach for this is.