refactor(gtest): removed use of read_state_bytes_using_wasm #4320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breathx
requested changes
Nov 4, 2024
gclient/src/api/rpc.rs
Outdated
| @@ -353,7 +354,8 @@ impl GearApi { | |||
| .await | |||
| } | |||
|
|
|||
| /// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path), but reads the program's state at the block identified by its hash. | |||
| /// Same as [`read_state_using_wasm_by_path`](Self::read_state_using_wasm_by_path), | |||
| /// but reads the program's state at the block identified by its hash. | |||
| pub async fn read_state_bytes_using_wasm_by_path_at( | |||
There was a problem hiding this comment.
gclient is not rpc or runtime api (it's client that call them), so as we agreed, rpc hole itself won't be removed atm, but each new user space libs shouldn't be able to call it, so feel free to remove it from here as well
There was a problem hiding this comment.
Right, additionally removed *_using_wasm functions from gclient and gsdk
breathx
added
A3-gotissues
Lazark0x
added
A0-pleasereview
# Conflicts: # gclient/src/api/rpc.rs # gsdk/src/rpc.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed from everywhere except rpc and runtime api