feat(ethexe-tx-pool): introduce proper tx pool integration with rpc and service #4427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to be review/merged after #4366.
It brings several updates:
AddTransaction
andCheckPreExecutionTransactionValidity
tasks are updated. Tests there mostly focus on the correctness of business logic and implementation (channels not panicking and etc.) stuff. The gossip test inethexe-cli
is now a base for an integration layer testing for the tx pool service.Transaction
trait is now an extension over several smaller traits defining behaviour for getting tx signature, hash, reference block hash and etc.TxPool*
related traits and types were removed.Some security considerations must be taken into account like the 1) window state while syncing, 2) not accepting txs when syncing, 3) proper (deterministic, same for all the nodes) order of execution of the transactions in the pool and etc. Everything is stated in todos marked with issue number in gh.