feat(ethexe/network): use proptest instead of custom mock

[playX18]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/network/src/lib.rs	32% smaller
ethexe/network/src/validator/topic.rs	11% smaller
Cargo.lock	Unsupported file format
ethexe/network/Cargo.toml	Unsupported file format
ethexe/network/src/injected.rs	0% smaller
ethexe/network/src/utils.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing capabilities of the ethexe/network module by transitioning from custom mock objects to property-based testing using the proptest crate. This change allows for more comprehensive validation of network logic through randomized input generation, significantly increasing the reliability of the test suite.

Highlights

• Testing Infrastructure: Replaced custom mock implementations with the proptest crate to improve test coverage and robustness.
• Test Utilities: Added a generic arb_value helper function to facilitate arbitrary value generation in tests.
• Dependency Management: Added proptest as a dependency and downgraded itertools to version 0.11 to maintain compatibility.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces property-based testing to the ethexe/network crate by integrating the proptest library. Key changes include the addition of an arb_value utility for generating arbitrary test data and the implementation of comprehensive property tests for validator message verification in validator/topic.rs. Feedback focuses on maintaining workspace consistency by using cargo hakari for dependency updates instead of manual edits, addressing reproducibility issues in the arb_value helper caused by random seeding in standard tests, and closing a verification gap for the CHAIN_HEAD_ERA - 1 boundary case in property tests.

[gemini-code-assist]

The property test proptest_too_old_messages_are_rejected uses the range 0u64..(CHAIN_HEAD_ERA - 1), which excludes CHAIN_HEAD_ERA - 1. Meanwhile, proptest_current_era_messages_from_current_validators_are_accepted only tests CHAIN_HEAD_ERA. This leaves the boundary case CHAIN_HEAD_ERA - 1 untested by property tests. Depending on the protocol rules, this era should either be accepted or rejected; the ranges should be adjusted to cover it and ensure no gaps in verification.

[playX18]

@codex review

[ark0f]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[ark0f]

Please, remove or rewrite proptests. The only property we want to test is relationship between era index in snapshot and message itself