Update MakeMaker's NAME argument to the "main module" Gearman::Client #3
Conversation
MakeMaker's NAME argument has to be set to the "main module" of the distribution and in this distribution it is considered Gearman::Client. For comparison, Template-Toolkit has NAME set to 'Template' and libwww-perl has NAME set to LWP. This information doesn't do anything useful other than making an entry in MYMETA files, perllocal.pod and (with cpanm) install.json metadata. I keep DISTNAME to Gearman so the tarball is still Gearman-VERSION.tar.gz and that makes distribution information and URLs on CPAN not change at all.
|
the real pain that can be remedied with this patch is described at perl-carton/carton#34 |
|
Bump? |
* set backtracker to github
* set backtracker to github
|
@miyagawa I did what you proposed but I have to revert to the old name because neither cpan nor testers identify the package by the name |
|
What do you mean by "CPAN nor testers identify the package by the name?" If you mean users of the module do not depend on this district the name "German::Client" there is no way you can add this module as a dependency. |
|
There are two different distributions on CPAN now. See CPAN User Directory. Same in cpantesters matrix:
I'm going to ask CPAN admins what is the best approach in this situation and I'll replay to you when I get an answer. |
|
That is because you changed the distribution name to -Client despite my original intent to keep it Gearman. If you have used make dist from the MakeMaker it would have generated it correctly. |
|
|
|
If you put DISTNAME it should be preferred. I don't know which version of
MakeMaker or other tool chain but something might be missing.
…On Sun, Dec 4, 2016, 12:46 PM Алексей Пастухов ***@***.***> wrote:
make dist produces Gearman-Client-*.tar.gz with regard to the NAME in
Makefile.PL
<https://github.com/p-alik/perl-Gearman/blob/master/Makefile.PL>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAANqxUdVdhvN14lVePAkbBI7pTCTa-Qks5rEyaLgaJpZM4AHTFX>
.
|
That's it! Many thanks for the advice. |
|
well, look at my PR, it's there already. If you were using it as is you would have saved all this hassle. |
|
You bet! I was careless. |
MakeMaker's NAME argument has to be set to the "main module" of the distribution and in this distribution it is considered Gearman::Client.
For comparison, Template-Toolkit has NAME set to 'Template' and libwww-perl has NAME set to LWP.