add CRS and drop Z coordinate + tests #473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
to be honest as you cannot build a featureCollection from a 3D file I think I would systematically drop the 3D part. In what configuration do you imagine we could need the 3D part ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trying to use
ee.FeatureCollection.geetools.fromGeoInterface()with 3D geometries, it fails. In this fix I let the user decide whether to drop the z coordinate or not, but it's an open discussion @12rambau. Do you consider it'd be better to do it every time, since GEE does not accept 3D geometries anyways. If so, the function will be simpler, with one param less.