-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/base example #190
Test/base example #190
Conversation
Clean up installed plugin to include only extlibs and python files.
@gena; the tests currently fail because of authentication (see the github run here). We need to add We did some due diligence to ensure the packaging matches the previous structure even with our refactoring, but we might have some blindspots in how things are published. From our research into the packaging CI and the |
* Move fixtures to separate conftest.py file The goal will be to reuse the fixture for other tests * Add unit test reproducing the bud * Fix bug adding vector layers by creating layers with the EE flag * Simplify code paths layer is a QgsRasterLayer in any case
We added our EE credentials to the secrets and the tests now pass. We flagged some future improvements on the CI that can be addressed at a later time. They mostly have the intent of optimizing the run (time): |
@@ -0,0 +1 @@ | |||
PYTHONPATH=${PYTHONPATH}:./extlibs:/Applications/QGIS-LTR.app/Contents/MacOS/lib/python3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love hardcoding these paths into our repo but I think we can refine that later. These are simply for developer experience so will just be an annoyance for any plugin developers with differing paths.
What I Changed
ee_plugin
folder (mainly to solve import errors for our tests)test/test_map.py
How to Test It
python -m pytest test
)Other Notes