Made changes to allow role to work with rpm-ostree systems #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of sequentially to save time
…le on rpm-ostree systems and all rhel/fedora variants accept /etc/systemd/system as a default location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed tasks/main.yml to make install task more efficient. Instead of looping packages sequentially, all packages can be installed simultaneously by passing the list of packages to the name parameter.
Added a reboot check to reboot the remote system if it is an rpm-ostree system and packages have been installed.
Changed the path for the systemd service from /lib to /etc. This allows the role to write its systemd service template as a dropin to the /etc/systemd/system folder, which is compatible with all rhel and fedora systems. The existing path, /lib/systemd/system is unwritable on rpm-ostree systems.
Edited the readme to add the need for
ansible_package_use = rpm_ostree_packageto be defined for the role to work with systems with rpm-ostree based immutable filesystems.