Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed master to control plane to be more compliant #107

Closed

Conversation

ra-beer
Copy link
Contributor

@ra-beer ra-beer commented May 27, 2021

Signed-off-by: ra-rau [email protected]

@stale
Copy link

stale bot commented Aug 25, 2021

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Aug 25, 2021
@geerlingguy
Copy link
Owner

geerlingguy commented Aug 25, 2021

Not stale, though it looks like this PR needs rebase — I was checking through changelogs and couldn't find when the change was officially made to update the nomenclature.

It looks like much of K8s docs now mention "control plane" instead of master, but there are still a lot of things (like the node taint property) that still use master as the terminology.

It's a little confusing IMO, but I would like to wait on merging something like this without also having a reference in this PR (just the comments, no need in code) to a K8s changelog message or release notes about the change (or even a relevant discussion), and also I'll need to tag a new major version because this would be a breaking change for role users.

(Edit: Closest discussion I could find is kubernetes/website#21621 — but I can't find any authoritative changelog / guide / document for the whole thing...)

@stale
Copy link

stale bot commented Aug 25, 2021

This issue is no longer marked for closure.

@stale stale bot removed the stale label Aug 25, 2021
@stale
Copy link

stale bot commented Nov 24, 2021

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

@stale stale bot added the stale label Nov 24, 2021
@stale
Copy link

stale bot commented Nov 24, 2021

This pull request is no longer marked for closure.

@stale stale bot removed the stale label Nov 24, 2021
@geerlingguy
Copy link
Owner

geerlingguy added a commit that referenced this pull request Sep 14, 2022
@geerlingguy
Copy link
Owner

See above commit—I added you as a co-author so hopefully github picks up the attribution accordingly... Further work will go into follow-ups.

geerlingguy added a commit that referenced this pull request Sep 14, 2022
geerlingguy added a commit that referenced this pull request Oct 26, 2022
weshouman added a commit to weshouman/ansible-for-devops that referenced this pull request Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants