-
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed master to control plane to be more compliant #107
Conversation
Signed-off-by: ra-rau <[email protected]>
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
Not stale, though it looks like this PR needs rebase — I was checking through changelogs and couldn't find when the change was officially made to update the nomenclature. It looks like much of K8s docs now mention "control plane" instead of master, but there are still a lot of things (like the node taint property) that still use It's a little confusing IMO, but I would like to wait on merging something like this without also having a reference in this PR (just the comments, no need in code) to a K8s changelog message or release notes about the change (or even a relevant discussion), and also I'll need to tag a new major version because this would be a breaking change for role users. (Edit: Closest discussion I could find is kubernetes/website#21621 — but I can't find any authoritative changelog / guide / document for the whole thing...) |
This issue is no longer marked for closure. |
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution! Please read this blog post to see the reasons why I mark pull requests as stale. |
This pull request is no longer marked for closure. |
Co-Authored-By: ra-rau <[email protected]>
See above commit—I added you as a co-author so hopefully github picks up the attribution accordingly... Further work will go into follow-ups. |
Co-authored-by: ra-rau <[email protected]>
Co-authored-by: ra-rau <[email protected]>
Reflecting: [PR107](geerlingguy/ansible-role-kubernetes#107)
Signed-off-by: ra-rau [email protected]