Skip to content

Move not, binary-{and,or}, and, or from examples/ to stdlib/ - #136

Closed
langston-barrett wants to merge 1 commit into
gelisam:mainfrom
langston-barrett:lb/bool
Closed

Move not, binary-{and,or}, and, or from examples/ to stdlib/#136
langston-barrett wants to merge 1 commit into
gelisam:mainfrom
langston-barrett:lb/bool

Conversation

@langston-barrett

Copy link
Copy Markdown
Collaborator

Progress on #54

@langston-barrett
langston-barrett requested a review from gelisam March 7, 2021 22:03
@doyougnu

Copy link
Copy Markdown
Collaborator

Unfortunately once #276 lands these functions need to be type aware and moved to stdlib so this PR will need to change :/

@gelisam

gelisam commented Nov 12, 2025

Copy link
Copy Markdown
Owner

Unfortunately once #276 lands these functions need to be type aware

why? these functions operate on booleans, e.g. binary-or is a two-argument version of or, not a bitwise or, so it doesn't have anything to do with the Word8s introduced in #276.

are you saying that while in Haskell, (||) and (.|.) are different operators from different names, in Klister you would like them to have the same name?

@doyougnu

Copy link
Copy Markdown
Collaborator

Ah no you are right. I didn't look too hard and thought these were bit ops.

@gelisam

gelisam commented Dec 6, 2025

Copy link
Copy Markdown
Owner

Ah, I was looking for and yesterday! It's in examples, not stdlib! It was a mistake to let this PR languish for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants