Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Time Accounting by Science Band #4556

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Display Time Accounting by Science Band #4556

merged 3 commits into from
Feb 13, 2025

Conversation

toddburnside
Copy link
Contributor

image

@bundlemon BundleMon
Copy link

bundlemon bot commented Feb 13, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ index-(hash).js
 1.74MB (-338B -0.02%) -
Unchanged files (7)
Status Path Size Limits
✅ exploreworkers-(hash).js
 597.86KB -
✅ index-(hash).css
 66.23KB -
✅ workbox-window.prod.es5-(hash).js
 2.07KB -
✅ agsworker-(hash).js
 83B -
✅ plotworker-(hash).js
 83B -
✅ catalogworker-(hash).js
 81B -
✅ itcworker-(hash).js
 81B -

Total files change -338B -0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@toddburnside toddburnside force-pushed the sc-3721-display-time-accounting-by-band branch from 8431cb8 to e40c9e7 Compare February 13, 2025 16:32
rpiaggio
rpiaggio reviewed Feb 13, 2025
View reviewed changes
explore/src/main/scala/explore/programs/TimeAccountingTable.scala Outdated
private type DataMap = Map[Option[ScienceBand], Either[TimeSpan, BigDecimal]]

extension (e: Either[TimeSpan, BigDecimal])
def toCell: VdomNode = e match
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Maybe we want private def toCell ?

rpiaggio
rpiaggio reviewed Feb 13, 2025
View reviewed changes
explore/src/main/scala/explore/programs/TimeAccountingTable.scala Outdated
case Right(bd) => f"${bd * 100}%.1f%%"

extension (l: List[BandedProgramTime])
def toTimeSpanMap: TimeSpanMap =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, private.

rpiaggio
rpiaggio reviewed Feb 13, 2025
View reviewed changes
explore/src/main/scala/explore/programs/TimeAccountingTable.scala
val completion: Row = completionRow(plannedMap, usedMap)
List(planned, used, completion)

// A Row is also used for the table metadata for creating the footer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

rpiaggio
rpiaggio approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with very minor comments.

@toddburnside toddburnside merged commit 458b4a2 into main Feb 13, 2025
14 checks passed
@toddburnside toddburnside deleted the sc-3721-display-time-accounting-by-band branch February 13, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpiaggio rpiaggio rpiaggio approved these changes

Assignees
No one assigned
Labels
common explore model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddburnside @rpiaggio