Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 5-second throttling to all subscriptions #4559

Closed
wants to merge 1 commit into from

Conversation

rpiaggio
Copy link
Contributor

No description provided.

Copy link

bundlemon bot commented Feb 13, 2025

BundleMon

Files updated (2)
Status Path Size Limits
exploreworkers-(hash).js
598.25KB (+399B +0.07%) -
index-(hash).js
1.74MB (-459B -0.03%) -
Unchanged files (6)
Status Path Size Limits
index-(hash).css
66.23KB -
workbox-window.prod.es5-(hash).js
2.07KB -
agsworker-(hash).js
87B -
catalogworker-(hash).js
87B -
itcworker-(hash).js
81B -
plotworker-(hash).js
77B -

Total files change -56B 0%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@toddburnside
Copy link
Contributor

toddburnside commented Feb 13, 2025

I'm not sure if this is quite what we want. It doesn't stop up from receiving the subscriptions and we already have the View mechanism in place for trying to avoid issues with updates from the server as well as the groupWithin. I'm afraid those could behave poorly in combination with this. I think it would be better to just throttle the queries that are triggered by the subscriptions - such as observation, program and group times updates.

Oh, plus the subscription events could be for different observations and this would drop events, right?

@rpiaggio
Copy link
Contributor Author

I completely agree with your comment, I'll have another go.

@rpiaggio
Copy link
Contributor Author

Closing in favor of #4560

@rpiaggio rpiaggio closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants