SC-4148 Reload atom every time the execution starts. #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
reviewed
Jan 28, 2025
| switch(id)(SequenceState.Idle) *> send(breakpointReached(id)) | ||
| } else | ||
| switch(id)(SequenceState.Running(false, false, false)) *> send(executing(id)) | ||
| switch(id)(SequenceState.Running(false, false, false, false)) *> send( |
There was a problem hiding this comment.
Shouldn't we do an atomReload when isStarting is true?
There was a problem hiding this comment.
No. isStarting is used to disable the breakpoint check in atomReload.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1607 +/- ##
==========================================
+ Coverage 30.21% 34.87% +4.65%
==========================================
Files 222 220 -2
Lines 10356 10671 +315
Branches 202 1315 +1113
==========================================
+ Hits 3129 3721 +592
+ Misses 7227 6950 -277 ☔ View full report in Codecov by Sentry. |
|
How it works: instead of scheduling the execution of the sequence, |
|
I see, thanks for the clarificiation |
jluhrs
deleted the
sc-4148-reload-step-after-continuing-from-a-breakpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.