Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit observations to ACCEPTED, or ENGINEERING or CALIBRATION programs #1617

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

toddburnside
Copy link
Contributor

@toddburnside toddburnside commented Feb 5, 2025

A similar WHERE should be used in the query in Observation.ts in navigate-ui.

Note, there is also an observationsByWorkflowState which would allow filtering by observation workflow state in addition to the WHERE used here. But, it is only available for service users, which I think means it can't be used here?

UPDATE: Rob made observationsByWorkflowState available to staff users. @hugo-vrijswijk is creating a PR for navigate-ui using that query. The exact query should be discussed in that PR and I will duplicate it here.

Hugo's PR: gemini-hlsw/navigate-ui#403

@rpiaggio
Copy link
Contributor

Now that the observationsByWorkflowState query is working in the ODB, we use that to get the candidate observations, with the same filters used in navigate.

Said query is only available for the STAFF role, so now the role is enforced in observe, even in dev.

Finally, there is a refactor regarding the model extensions: now the extensions are all in their own file, separate from package.

@rpiaggio rpiaggio marked this pull request as ready for review February 13, 2025 16:37
Copy link
Contributor Author

@toddburnside toddburnside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :D

@rpiaggio rpiaggio merged commit 08bfa67 into main Feb 13, 2025
10 checks passed
@rpiaggio rpiaggio deleted the observation-query branch February 13, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants