Implement role cleanup on professor/student deletion to prevent orphaned user roles

app/models/professor.rb

@@ -43,6 +43,8 @@ class Professor < ApplicationRecord
   validates :enrollment_number, uniqueness: true, allow_blank: true
   validate :changed_to_different_user
 
+  before_destroy :handle_user_role_removal
+
   def create_advisement_points_of_level_method(column_name)
     self.class.send(:define_method, column_name) {
       advisement_points(column_name[26..-1])
@@ -130,4 +132,22 @@ def changed_to_different_user
       errors.add(:user, :changed_to_different_user)
     end
   end
+
+  private
+    def handle_user_role_removal
+      return unless user.present?
+
+      professor_role = Role.find_by(id: Role::ROLE_PROFESSOR)
+      if user.roles.include?(professor_role)
+        user.roles.delete(professor_role)
+
+        user.roles << Role.find_by(id: Role::ROLE_DESCONHECIDO) if user.roles.empty?
+
+        if user.actual_role == Role::ROLE_PROFESSOR
+          user.actual_role = user.user_max_role || Role::ROLE_DESCONHECIDO
+        end
+
+        user.save!
+      end
+    end
 end

app/models/student.rb

@@ -35,6 +35,8 @@ class Student < ApplicationRecord
   validates :cpf, presence: true, uniqueness: true
   validate :changed_to_different_user
 
+  before_destroy :handle_user_role_removal
+
   accepts_nested_attributes_for :student_majors, allow_destroy: true
 
   before_save :set_birth_state_by_birth_city
@@ -106,4 +108,22 @@ def changed_to_different_user
     def set_birth_state_by_birth_city
       self.birth_state_id = birth_city.state_id unless birth_city.blank?
     end
+
+  private
+    def handle_user_role_removal
+      return unless user.present?
+
+      student_role = Role.find_by(id: Role::ROLE_ALUNO)
+      if user.roles.include?(student_role)
+        user.roles.delete(student_role)
+
+        user.roles << Role.find_by(id: Role::ROLE_DESCONHECIDO) if user.roles.empty?
+
+        if user.actual_role == Role::ROLE_ALUNO
+          user.actual_role = user.user_max_role || Role::ROLE_DESCONHECIDO
+        end
+
+        user.save!
+      end
+    end
 end

spec/models/professor_spec.rb

@@ -286,4 +286,39 @@
       end
     end
   end
+
+  describe "Before destroy" do
+    it "should assign unknown role when user has only professor role" do
+      @destroy_later << FactoryBot.create(:role_desconhecido)
+      @destroy_later << user = FactoryBot.create(:user, actual_role: Role::ROLE_PROFESSOR)
+      @destroy_later << professor = FactoryBot.create(:professor, user: user)
+      user.roles << @professor_role
+      user.save!
+
+      professor.destroy
+      user.reload
+
+      expect(user.roles.count).to eq(1)
+      expect(user.roles).not_to include(@professor_role)
+      expect(user.roles.first.id).to eq(Role::ROLE_DESCONHECIDO)
+      expect(user.actual_role).to eq(Role::ROLE_DESCONHECIDO)
+    end
+
+    it "should keep other roles when user has multiple roles" do
+      @destroy_later << admin_role = FactoryBot.create(:role_administrador)
+      @destroy_later << user = FactoryBot.create(:user, actual_role: Role::ROLE_ADMINISTRADOR)
+      @destroy_later << professor = FactoryBot.create(:professor, user: user)
+      user.roles << @professor_role
+      user.roles << admin_role
+      user.save!
+
+      professor.destroy
+      user.reload
+
+      expect(user.roles.count).to eq(1)
+      expect(user.roles).to include(admin_role)
+      expect(user.roles).not_to include(@professor_role)
+      expect(user.actual_role).to eq(Role::ROLE_ADMINISTRADOR)
+    end
+  end
 end

spec/models/student_spec.rb

@@ -177,4 +177,39 @@
       expect(student.birth_state).to eq(birth_state)
     end
   end
+
+  describe "Before destroy" do
+    it "should assign unknown role when user has only student role" do
+      @destroy_later << FactoryBot.create(:role_desconhecido)
+      @destroy_later << user = FactoryBot.create(:user, actual_role: Role::ROLE_ALUNO)
+      @destroy_later << student = FactoryBot.create(:student, user: user)
+      user.roles << @role_aluno
+      user.save!
+
+      student.destroy
+      user.reload
+
+      expect(user.roles.count).to eq(1)
+      expect(user.roles).not_to include(@role_aluno)
+      expect(user.roles.first.id).to eq(Role::ROLE_DESCONHECIDO)
+      expect(user.actual_role).to eq(Role::ROLE_DESCONHECIDO)
+    end
+
+    it "should keep other roles when user has multiple roles" do
+      @destroy_later << admin_role = FactoryBot.create(:role_administrador)
+      @destroy_later << user = FactoryBot.create(:user, actual_role: Role::ROLE_ADMINISTRADOR)
+      @destroy_later << student = FactoryBot.create(:student, user: user)
+      user.roles << @role_aluno
+      user.roles << admin_role
+      user.save!
+
+      student.destroy
+      user.reload
+
+      expect(user.roles.count).to eq(1)
+      expect(user.roles).to include(admin_role)
+      expect(user.roles).not_to include(@role_aluno)
+      expect(user.actual_role).to eq(Role::ROLE_ADMINISTRADOR)
+    end
+  end
 end