composable requirements #91
Conversation
| class NegativeRequirement(Requirement): | ||
| def __init__(self, requirement: Requirement,): | ||
| self.requirement = requirement | ||
|
|
There was a problem hiding this comment.
This is kind of a weird thing to prompt with. But it's hard to know what a reasonable prompt would be here.
| class ConjunctiveRequirement(Requirement): | ||
| def __init__(self, requirements: list[Requirement],): | ||
| self.requirements = requirements | ||
|
|
||
| @property | ||
| def description(self): | ||
| return "\n* ".join( | ||
| ["Satisfy all of these requirements:"] + \ | ||
| [r.description for r in self.requirements]) | ||
|
|
||
| def validate(self, *args, **kwargs): | ||
| results = [r.validate(*args, **kwargs) for r in self.requirements] | ||
| return ValidationResult( | ||
| result = all(results), | ||
| reason = "\n* ".join( | ||
| ["These requirements are not satisfied:"]+ | ||
| [r.reason for r in results if not r]), | ||
| score = max([r.score for r in results if not r])) |
There was a problem hiding this comment.
In the rest of Mellea, a list of requirements is implicitly conjunctive. So does it make sense to have a ConjunctiveRequirement that behaves differently from a list of reuqirements? Or should we explicitly not have ConjunctiveRequirements because the correct way of doing this is to pass both into the requirements= kwarg?
| @property | ||
| def description(self): |
There was a problem hiding this comment.
description is NOT a @property on the base class or in other Requirement types. Maybe it should be, but we should do this the same everywhere. Using property here but not in the other Requirement classes seems like a recipe for confusion down the road.
|
There are failing quality checks. Please use the pre-commit hooks. Assuming you have already created a venv and installed Mellea (editable), you can install the hooks by running the following commands in the root of your mellea checkout: uv pip install -e . --group dev && pre-commit installOnce installed, you can still commit over errors using the |
work in progress sketch for discussion
#22