feat: add test suite for autosign.bash #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbat2
force-pushed
the
gpg-local-user-v2
branch
from
07f2c10 to
f8904f9
Compare
mgorny
requested changes
Dec 15, 2024
Member
mgorny
left a comment
mgorny
left a comment
There was a problem hiding this comment.
Please use consistent coding style, fix whitespace and add error handling, for a start.
robbat2
force-pushed
the
gpg-local-user-v2
branch
from
f8904f9 to
a364c61
Compare
Author
|
@mgorny you can recheck it; it does pass on woodpecker btw |
mgorny
reviewed
Dec 16, 2024
Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
robbat2
force-pushed
the
gpg-local-user-v2
branch
from
a364c61 to
83e8045
Compare
Author
|
What format-checker do you recommend then since neither shfmt-3.1.2 nor shellcheck-0.10.0 are catching these, and I missed two inconsistencies only. |
Member
|
I have never used a formatter for shell code. |
mgorny
reviewed
Dec 16, 2024
| export AUTOSIGN_TMPDIR GNUPGHOME | ||
| echo "Testing tmpdir is ${AUTOSIGN_TMPDIR}" | ||
|
|
||
| umask 077 && mkdir -p "${GNUPGHOME}" |
| echo "Testing tmpdir is ${AUTOSIGN_TMPDIR}" | ||
|
|
||
| umask 077 && mkdir -p "${GNUPGHOME}" | ||
| [[ -n ${AUTOSIGN_NO_SEND_KEYS} ]] || echo "keyserver ${LOCAL_KEYSERVER}" >"${GNUPGHOME}"/gpg.conf |
| # this is to ensure there are other secret keys, and we aren't just lucky with the | ||
| # code picking a random key that was the correct one for the key. | ||
| for f in {1..4}; do | ||
| gpg --batch --passphrase '' --quick-gen-key "Dummy Key 0x$(printf %04x "${f}")" |
| } | ||
|
|
||
| echo "Generating authority keys ..." | ||
| gpg -q --batch --passphrase '' --quick-gen-key "${authuid_foo}" |
| echo "Generating authority keys ..." | ||
| gpg -q --batch --passphrase '' --quick-gen-key "${authuid_foo}" | ||
| authfpr_foo=$( | ||
| gpg --with-colon --list-secret-keys "${authuid_foo}" | gpg_colon_get_sec_fpr |
Member
There was a problem hiding this comment.
Suggested change
| gpg --with-colon --list-secret-keys "${authuid_foo}" | gpg_colon_get_sec_fpr | |
| gpg_colon_get_sec_fpr < <(gpg --with-colon --list-secret-keys "${authuid_foo}") |
Also no error handling.
| gpg --with-colons --check-sig \ | ||
| --trusted-key "${authfpr_foo}" \ | ||
| --trusted-key "${authfpr_bar}" \ | ||
| >"${AUTOSIGN_TMPDIR}"/verification-${n}.txt |
| gpg --with-colons --check-sig \ | ||
| --trusted-key "${authfpr_foo}" \ | ||
| --trusted-key "${authfpr_bar}" \ | ||
| >"${AUTOSIGN_TMPDIR}"/verification-${n}.txt |
| <(grep -E -e '^uid:.:.*\<a[^@]+@gentoo.org>:' <"${AUTOSIGN_TMPDIR}"/verification-03.txt) \ | ||
| <(grep -E -e '^uid:.:.*\<a[^@]+@gentoo.org>:' <"${AUTOSIGN_TMPDIR}"/verification-04.txt) \ | ||
| -I '^tru:' \ | ||
| >"${AUTOSIGN_TMPDIR}"/diff-03-04.txt |
| <(grep -E -e '^uid:.:.*\<a[^@]+@gentoo.org>:' <"${AUTOSIGN_TMPDIR}"/verification-04.txt) \ | ||
| -I '^tru:' \ | ||
| >"${AUTOSIGN_TMPDIR}"/diff-03-04.txt | ||
| cat "${AUTOSIGN_TMPDIR}"/diff-03-04.txt |
Comment on lines
+157
to
+158
| AUTOSIGN_TMPDIR=${AUTOSIGN_TMPDIR}/${n}-foo/ AUTOSIGN_GPG_LOCAL_FPR=${authfpr_foo} bash ./autosign.bash | ||
| AUTOSIGN_TMPDIR=${AUTOSIGN_TMPDIR}/${n}-bar/ AUTOSIGN_GPG_LOCAL_FPR=${authfpr_bar} bash ./autosign.bash |
Member
There was a problem hiding this comment.
I think we want to check for unsuccessful return here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redoing #1 work - starting with test suite before any changes.
Signed-off-by: Robin H. Johnson robbat2@gentoo.org