-
Notifications
You must be signed in to change notification settings - Fork 12
feat(manager): measurement editing #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
...to avoid a cyclic dependency in OgrDatasetComponent.
| <input matInput type="text" formControlName="spatialReference" /> | ||
| </mat-form-field> | ||
|
|
||
| <mat-form-field class="column"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include some sort of indication in the UI that this section is meant for setting the measurement? Alternatively, would it maybe make sense to have the "geoengine-measurement" appear directly below the "Integer Columns" etc. fields when one clicks on a column name/enters a new one there? It might be more intuitive to have it directly there, associated with the column definition and would be neat to have it only appear when actively editing the column names this way and hidden otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could change it s.t. the measurement appears underneath the selected column. However I would need to track which column is selected etc. ..a little bit more code.
| </mat-form-field> | ||
|
|
||
| <ng-container *ngIf="metaData as meta"> | ||
| <geoengine-measurement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good to add an indication that the measurement is set in this section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
We discussed this elsewhere, but this is the commit, relating to the idea to filter out the text columns from the classification |
6c86579 to
cfcd2a5
Compare

Allows for changing the
Measurementsin theLoadingInformationfor Gdal and Ogr Sources.GdalSources
OgrSources
Currently the
class valuesfor theclassification measurementare typed for integers other input is not allowed.I think this makes it impossible for declaring a proper classification measurement for
textorfloatcolumns.I did not implement this in the frontend yet, as I've seen that the backend defines the type as
and I am not 100% sure if this should be even possible.
Changes I've made
Measurement Component
MeasurementComponenthas been made a standalone component. I made this change, because I got a cyclic import problem with using theMeasurementComponentin theOgrDatasetComponent.@Output() onInputChange = new EventEmitter<Event>();that fires every time one of the text input fields changes (used to mark the form as dirty)@Output() measurementChange = new EventEmitter<Measurement>();now fires after measurement changes (didnt fire at all before)constructortongOnChangeand setup the measurement appropriately if one is given as@InputGdalMetadataListComponent and OgrDatasetComponent
MeasurementComponentOgrDatasetComponent
OnInitto setup the currently selected column for the measurement component