Implement some best practices, fix error in static_ips test & avoid excessive regex calls when line is not spruce line #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I've made a few changes, the biggest one being the
matchPattern
function which should make spruce much faster especially when rendering larges files.If you are open to a review (& possible merge), I ask you to do it thoroughly as I don't have much experience with Go.
Here is a benchmark comparsion from our tool, which uses spruce under the hood:
Before:
After:
Memory consumption went down from ~60GB to ~1GB, so much less garbage collection.