fix(upsert): handle missing version.message in only-changed mode#55
Open
geopanther wants to merge 1 commit into
Open
fix(upsert): handle missing version.message in only-changed mode#55geopanther wants to merge 1 commit into
geopanther wants to merge 1 commit into
Conversation
Older self-hosted Confluence servers don't populate version.message on page create. Accessing it directly causes an AttributeError when using --only-changed. Guard with hasattr() and treat missing message as 'needs update'. Also guards the same pattern for attachments. Adapted from iamjackg/md2cf#135 by @briandcho.
Owner
Author
Maintainer ReviewVerdict: ✅ Approve Real-world bug fix. Older self-hosted Confluence (and potentially Cloud edge cases) may not populate Good: Extended the same fix to attachment hash matching (line 192 in original), which the upstream PR didn't cover. This prevents the same crash when using Suggestion for future: Consider wrapping this pattern in a small helper like No concerns. Ship it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard against
AttributeErrorwhenexisting_page.version.messageis absent on older self-hosted Confluence servers that don't populateversion.messageon page creation.Adapted from iamjackg/md2cf#135 by @briandcho.
Changes
hasattr()check before accessingversion.messagefor both pages and attachmentsTests
test_page_needs_updating_when_no_message