feat(document): add parent title prefix via .pages file#57
Open
geopanther wants to merge 1 commit into
Open
Conversation
Support `add-parent-title-as-prefix: true` in `.pages` YAML files to prefix child page titles with the folder's title. Resolves title collisions when multiple folders contain identically-named documents (e.g., folder1/overview.md and folder2/overview.md). Adapted from iamjackg/md2cf#127 by @jeffmercerVG.
Owner
Author
Maintainer ReviewVerdict: ✅ Approve with suggestions Addresses a real Confluence constraint — all pages in a space must have unique titles. The Good:
Suggestions (non-blocking):
Compared to upstream: Our adaptation is cleaner — the original PR had a formatting-only change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support
add-parent-title-as-prefix: truein.pagesYAML files to prefix child page titles with the folder's title. Resolves title collisions when multiple folders contain identically-named documents (e.g.,folder1/overview.mdandfolder2/overview.md→ "Folder1 overview" and "Folder2 overview").Adapted from iamjackg/md2cf#127 by @jeffmercerVG.
Changes
add-parent-title-as-prefixfrom.pagesYAML filesNonevalues on both parent and page titlesTests
test_get_pages_from_directory_with_pages_file_multi_level_conflicting_titles