Skip to content

Commit

Permalink
Fix parallel issues in KPP standalone interface; Add structural updates
Browse files Browse the repository at this point in the history
.gitignore
- Also ignore *.exe files

GeosCore/fullchem_mod.F90
- Remove State_Grid from call to Check_ActiveCell

GeosCore/kpp_standalone_interface.F90
- Updated subroutine header comments
- Added cosmetic changes for clarity (mostly making code fit within
  80 characters, for better readability)
- Removed Active_Cell and Active_Cell_name from the
  KPP_Standalone_Interface_Type (should have been done previously)
- Remove State_Grid argument from Check_ActiveCell, this was only
  used for debugging.   Also removed commented out debug prints.
- Use Format statements with write statments where expedient
- Echo a message when the KPP standalone interface is manually disabled
  (i.e. when settings:activate = false)
- Added display of location names and lon/lats at end of the routine
  Config_KPP_Standalone
- In routine Write_Samples, wrap file I/O in an !$OMP CRITICAL block,
  in order to prevent more than one thread from writing to each file.
- Removed RETURN statement from within !$OMP CRITICAL block, this
  is not allowed.
- Bug fix: Write Kpp_Standalone_ActiveCell%Active_Cell_Name to file,
  and not Kpp_Standalone_YAML%Active_Cell_Name (which has been removed).

Signed-off-by: Bob Yantosca <[email protected]>
  • Loading branch information
yantosca committed Oct 4, 2024
1 parent 711e09d commit 73bd391
Show file tree
Hide file tree
Showing 3 changed files with 377 additions and 220 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,5 @@ build/
build_*/
*___.h
*___.rc
core.*
core.*
*.exe
5 changes: 2 additions & 3 deletions GeosCore/fullchem_mod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -583,9 +583,8 @@ SUBROUTINE Do_FullChem( Input_Opt, State_Chm, State_Diag, &

! Check if the current grid cell in this loop should have its
! full chemical state printed (concentrations, rates, constants)
! for use with the KPP Standalone
! (psturm, 03/22/24)
CALL Check_ActiveCell( I, J, L, State_Grid )
! for use with the KPP Standalone (psturm, 03/22/24)
CALL Check_ActiveCell( I, J, L )

! Start measuring KPP-related routine timing for this grid box
IF ( State_Diag%Archive_KppTime ) THEN
Expand Down
Loading

0 comments on commit 73bd391

Please sign in to comment.