Say why se_method is withheld from estimate - #19
Merged
Conversation
`run_pipeline` and `evaluate_scene` take `se_method` and do not pass it to `estimate`. That looks exactly like the ci_level bug fixed in #18 and is the opposite: the sweep wants `estimate` to compute every SE from one fit so `_method_ci` can pick afterwards and the methods are compared on identical draws. Passing it would defeat the comparison. The comment says so, and the marker keeps preen's dropped-args check (gojiplus/preen#62) quiet on a case that is correct. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YDg9BEDJgFhsixKFjAquNm
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_pipelineandevaluate_scenetakese_methodand don't pass it toestimate. That looks exactly like theci_levelbug fixed in #18, and it's the opposite: the sweep wantsestimateto compute every SE from one fit so_method_cican select afterwards, and the methods are compared on identical draws. Passing it would defeat the comparison.Two lines of comment saying so, plus the
# preen: allow-dropped-argmarker that keeps gojiplus/preen#62's check quiet on a case that is correct. The comment earns its place either way — this is the third time in this file that an unforwarded parameter turned out to matter, so the two that don't should say why.🤖 Generated with Claude Code
https://claude.ai/code/session_01YDg9BEDJgFhsixKFjAquNm