Layer Selection Plugin on ArcGIS, WFS & WMS layers #11119
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| import React from 'react'; | ||
| import { connect } from 'react-redux'; | ||
| import { createSelector } from 'reselect'; | ||
| import { get } from 'lodash'; | ||
| import { Glyphicon } from 'react-bootstrap'; | ||
|
|
||
| import { createPlugin } from '../utils/PluginsUtils'; | ||
| import { layersSelector } from '../selectors/layers'; | ||
| import { updateNode, addLayer, changeLayerProperties } from '../actions/layers'; | ||
| import { zoomToExtent } from '../actions/map'; | ||
| import controls from '../reducers/controls'; | ||
| import { toggleControl } from '../actions/controls'; | ||
| import Message from '../components/I18N/Message'; | ||
|
|
||
| import SelectComponent from './layersSelection/components/LayersSelection'; | ||
| import epics from './layersSelection/epics/layersSelection'; | ||
| import select from './layersSelection/reducers/layersSelection'; | ||
| import { storeConfiguration, cleanSelection, addOrUpdateSelection } from './layersSelection/actions/layersSelection'; | ||
| import { getSelectSelections, getSelectQueryMaxFeatureCount } from './layersSelection/selectors/layersSelection'; | ||
|
|
||
| /** | ||
| * Select plugin that enables layer feature selection in the map. | ||
| * It connects Redux state and actions to the SelectComponent UI. | ||
| * Uses selectors to retrieve visibility, layers, selection results, and feature count. | ||
| * | ||
| * @function | ||
| * @returns {Object} A plugin definition object used by the application to render and control the Select tool. | ||
| */ | ||
| export default createPlugin('LayersSelection', { | ||
| component: connect( | ||
| createSelector([ | ||
| (state) => get(state, 'controls.select.enabled'), | ||
| layersSelector, | ||
| getSelectSelections, | ||
| getSelectQueryMaxFeatureCount | ||
| ], (isVisible, layers, selections, maxFeatureCount) => ({ | ||
| isVisible, | ||
| layers, | ||
| selections, | ||
| maxFeatureCount | ||
| })), | ||
| { | ||
| onClose: toggleControl.bind(null, 'select', null), | ||
| onUpdateNode: updateNode, | ||
| storeConfiguration, | ||
| cleanSelection, | ||
| addOrUpdateSelection, | ||
| zoomToExtent, | ||
| addLayer, | ||
| changeLayerProperties | ||
| } | ||
| )(SelectComponent), | ||
| options: { | ||
| disablePluginIf: "{state('mapType') === 'cesium'}" | ||
| }, | ||
| reducers: { | ||
| ...controls, | ||
| select | ||
| }, | ||
| epics: epics, | ||
| containers: { | ||
| BurgerMenu: { | ||
| name: 'select', | ||
| position: 1000, | ||
| priority: 2, | ||
| doNotHide: true, | ||
| text: <Message msgId="layersSelection.title"/>, | ||
| tooltip: <Message msgId="layersSelection.tooltip"/>, | ||
| icon: <Glyphicon glyph="hand-down"/>, | ||
| action: toggleControl.bind(null, 'select', null), | ||
| toggle: true | ||
| }, | ||
| SidebarMenu: { | ||
| name: 'select', | ||
| position: 1000, | ||
| priority: 1, | ||
| doNotHide: true, | ||
| text: <Message msgId="layersSelection.title"/>, | ||
| tooltip: <Message msgId="layersSelection.tooltip"/>, | ||
| icon: <Glyphicon glyph="hand-down"/>, | ||
| action: toggleControl.bind(null, 'select', null), | ||
| toggle: true | ||
| }, | ||
| Toolbar: { | ||
| name: 'select', | ||
| alwaysVisible: true, | ||
| position: 2, | ||
| priority: 0, | ||
| doNotHide: true, | ||
| tooltip: <Message msgId="layersSelection.title"/>, | ||
| icon: <Glyphicon glyph="hand-down"/>, | ||
| action: toggleControl.bind(null, 'select', null), | ||
| toggle: true | ||
| } | ||
| } | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| export const SELECT_CLEAN_SELECTION = "SELECT:CLEAN_SELECTION"; | ||
| export const SELECT_STORE_CFG = "SELECT:STORE_CFG"; | ||
| export const ADD_OR_UPDATE_SELECTION = "SELECT:ADD_OR_UPDATE_SELECTION"; | ||
|
|
||
| /** | ||
| * Action creator to clean the current selection based on geometry type. | ||
| * | ||
| * @param {string} geomType - The type of geometry to clean (e.g., "Point", "Polygon"). | ||
| * @returns {{ type: string, geomType: string }} The action object. | ||
| */ | ||
| export function cleanSelection(geomType) { | ||
| return { | ||
| type: SELECT_CLEAN_SELECTION, | ||
| geomType | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Action creator to store configuration settings related to selection. | ||
| * | ||
| * @param {Object} cfg - Configuration object to store. | ||
| * @returns {{ type: string, cfg: Object }} The action object. | ||
| */ | ||
| export function storeConfiguration(cfg) { | ||
| return { | ||
| type: SELECT_STORE_CFG, | ||
| cfg | ||
| }; | ||
| } | ||
|
|
||
| /** | ||
| * Action creator to add or update a layer selection with GeoJSON data. | ||
| * | ||
| * @param {string} layer - The name or ID of the layer. | ||
| * @param {Object} geoJsonData - The GeoJSON data representing the selection. | ||
| * @returns {{ type: string, layer: string, geoJsonData: Object }} The action object. | ||
| */ | ||
| export function addOrUpdateSelection(layer, geoJsonData) { | ||
| return { | ||
| type: ADD_OR_UPDATE_SELECTION, | ||
| layer, | ||
| geoJsonData | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| .ms-resizable-modal > .modal-content.select-dialog { | ||
| top: 0vh; | ||
| right: -100vw; | ||
| } | ||
|
|
||
| .select-content * .ms-node-title { | ||
| font-weight: bold; | ||
| } | ||
|
|
||
| .select-content * .ms-node-header-info > .ms-node-header-addons:nth-child(3) { | ||
| flex: 1 ; | ||
| justify-content: space-between; | ||
| } | ||
|
|
||
| .features-count-displayer{ | ||
| display: flex; | ||
| } | ||
|
|
||
| .title-container { | ||
| display: flex; | ||
| } | ||
|
|
||
| .title-icon { | ||
| height: 100%; | ||
| width: auto; | ||
| margin-right: 0.5em; | ||
| } | ||
|
|
||
| .title-title { | ||
| flex-grow: 1; | ||
| text-align: center; | ||
| } | ||
|
|
||
| .tree-header { | ||
| background-color: #E9EDF4; | ||
| } | ||
|
|
||
| .features-count { | ||
| font-weight: bold; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| .ellipsis-container { | ||
| position: relative; | ||
| display: inline-block; | ||
| opacity: 1; | ||
| } | ||
|
|
||
| .ellipsis-button { | ||
| padding: 2%; | ||
| background-color: lightgray; | ||
|
Contributor
There was a problem hiding this comment. All the styles related to theme colors should be included in the lesscss files under a including a new file with the name of plugin, in this case layer-selection.less. This is needed to use variables instead of hardcoded value for colors |
||
| /* border: none; */ | ||
| border: 1px solid #ccc; | ||
| border-radius: 50%; | ||
| /* font-size: 16px; */ | ||
| font-weight: bold; | ||
| cursor: pointer; | ||
| text-align: center; | ||
| line-height: 1; | ||
| } | ||
|
|
||
| .ellipsis-button:hover { | ||
| background-color: #e0e0e0; | ||
| } | ||
|
|
||
| .ellipsis-menu { | ||
| position: absolute; | ||
| top: 100%; | ||
| right: 0; | ||
| background-color: white; | ||
| border: 1px solid #ccc; | ||
| border-radius: 5px; | ||
| /* margin-top: 5px; */ | ||
| box-shadow: 0 2px 5px rgba(0, 0, 0, 0.1); | ||
| z-index: 1; | ||
| width: 10vw; | ||
| } | ||
|
|
||
| .ellipsis-menu p { | ||
| margin: 0; | ||
| padding: 5%; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .ellipsis-menu p:hover { | ||
| background-color: #f0f0f0; | ||
| } | ||
|
|
||
| .export-toggle { | ||
| display: flex; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| cursor: pointer; | ||
| padding: 5px 10px; | ||
| } | ||
|
|
||
| .export-toggle span:nth-of-type(2) { | ||
| font-weight: bold; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A reducer should not be spread. In this case if we want also to ensure controls reducer is included we should review reducers as:
And instead of
selectI propose to change the name of reducer tolayersSelection