Skip to content

Conversation

@congchen1101
Copy link
Contributor

fix(TOC layer-settings): preserve description when switching between tabs

  • Fixed an issue where a layer’s description shown in the General tab disappeared after navigating to the Style tab and back
  • Prevent overwriting description if capabilities.Abstract is empty or undefined
  • Add test to verify description persistence when Abstract is missing

On behalf of DB Systel GmbH

Description

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

What is the current behavior?

#11397

What is the new behavior?
Layer’s description will not disappear after navigating to the Style tab and back

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

fix(TOC layer-settings): preserve description when switching between tabs

- Fixed an issue where a layer’s description shown in the General tab
  disappeared after navigating to the Style tab and back
- Prevent overwriting description if capabilities.Abstract is empty or undefined
- Add test to verify description persistence when Abstract is missing

On behalf of DB Systel GmbH
@tdipisa
Copy link
Member

tdipisa commented Aug 22, 2025

@congchen1101 thank you for your contribution. Anyway, I've checked on the same map you indicated in the connected issue but I'm not reproducing the problem. All seems working as expected. Are there maybe other preconditions to respect to reproduce the problem?

@tdipisa tdipisa requested a review from allyoucanmap August 22, 2025 13:56
@tdipisa tdipisa added bug BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch External Contribution labels Aug 22, 2025
@tdipisa tdipisa added this to the 2025.01.02 milestone Aug 22, 2025
@congchen1101
Copy link
Contributor Author

Hi @tdipisa,
thanks for checking. Please make sure the selected layer already has a description, but that this description does not come from the corresponding GeoServer abstract field. Then switch to the Style tab and back to General—you should see the issue.

The video I shared was recorded today, and I have just checked again — the bug is still present when performing the exact steps on the layer poly_landmarks. There are no other preconditions and this layer should meet all the required conditions.

@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Aug 28, 2025
@tdipisa tdipisa modified the milestones: 2025.01.02, 2025.02.00 Aug 28, 2025
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 4, 2025
@tdipisa tdipisa modified the milestones: 2025.02.00, 2025.02.01 Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch bug External Contribution ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TOC: Layer description disappears after switching between General and Style tabs in Layer Settings

5 participants