Fix #11616 Include geonode-#.#.x branches to build and CI workflows #11617
Conversation
tdipisa
added
the
BackportNeeded
|
Maybe a backport here is not necessary @offtherailz. Up to you to consider that better. |
| - '[cC][0-9][0-9][0-9]-+**' # c123 or c123-something for custom branch | ||
| - '[0-9][0-9][0-9][0-9].[0-9][0-9].xx' # stable brances. E.g. 2021.01.xx | ||
| - '[0-9][0-9][0-9][0-9].[0-9][0-9].xx' # stable branches. E.g. 2021.01.xx | ||
| - '[geonode]-[0-9].[0-9].x' # stable branches for GeoNode. E.g. geonode-4.4.x |
There was a problem hiding this comment.
This may cause accidental deploy on maven from different branches.
see https://github.com/geosolutions-it/MapStore2/pull/11617/files#diff-3ab46ee209a127470fce3c2cf106b1a1dbadbb929a4b5b13656a4bc4ce19c0b8R156
If now we have the branches with -SNAPSHOT version that are always different, and this limitates the effects, with this changes we may have different version deploying randomly.
Effectively this can happen also from cXXX branch, so maybe a different support. So maybe we have to add in the if lined a filter by branch.
There was a problem hiding this comment.
Is technically on but I figure out a possible problem (that may involve also cXXX branches).
If we build the same -SNAPSHOT or the same fixed version, the last build may override the current maven deployed packages with udesired builds of a side project.
This may become complicated.
we can approve this PR, but this will increase the possibilities of failure, so we should at least open an issue to prevent this.
I clarify:
- the build-publish works on all push events on geosolutions repo, on every branch used.
- This is ok for master and 202x.xx.xx that contain the desired snapshot or fixed version
- If or geonodeX.x pushes at sometimes, mapstore-services and war will be pushed for the version written
- This is a potential issue also for cXXX brances.
I'd suggest to add to the if clausole a condition on branch or open a dedicated issue.
I did an attempts. We can check if it works as expected.
|
@allyoucanmap I did the improvement on my own. I only ask you, when merging this and the backport, to figure out if publish is running on master and stable branch, and skipped when building geonode branch. |
|
@ElenaGallo no tests needed here, @allyoucanmap you can backport, checking these ones. |
3 participants
Description
This PR adds geonode
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11616
What is the new behavior?
Added geonode-#.#.x branches to CI and build workflows
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information