Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] move storyboard component over #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

wenjzhu
Copy link

@wenjzhu wenjzhu commented Mar 15, 2021

Not very ready but feel free to leave comments.

based on max's pr, I moved more stuff from gl-gltg to here.

  • It seems the storyboard is potentially needed, so I moved /data-stories (hopefully that is the right thing refers to "storyboard")
  • moved the /image, /style etc
  • will update upon further discussion and requirements

@wenjzhu wenjzhu requested review from ka7eh and max-zilla March 15, 2021 20:16
@ka7eh
Copy link

ka7eh commented Mar 17, 2021

Data stories is a git submodule in geodashboard. The reason for this is so a non-developer can create/update slides and add them to the submodule without having to deal with the codebase. I'm not sure if that's still the case. We should check with the team this week and see if it makes sense to keep that part of the code as a submodule. If not, then we can include the slides directly in this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants