-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): bare minimum "light switch" example #322
feat(examples): bare minimum "light switch" example #322
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
- Coverage 84.89% 84.26% -0.63%
==========================================
Files 15 14 -1
Lines 1225 1157 -68
==========================================
- Hits 1040 975 -65
+ Misses 185 182 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @zachwaite, thanks a lot for your PR! Neat idea 😄 As you may see I haven't been updating the crate in some time (life got in the way 😅) and I notice that there are some linting errors from clippy related to dependency versions. I'll see if I can fix them in the next few days, and review the code properly. Thank you again for your time and effort 🙏🏻 |
@ar3s3ru No expectations from me about updates. I'm also willing to do more work on getting the checks to pass, but wasn't sure you were interested in contributions. Since it seems like you are, I'll take another pass. The Thanks for replying to my PR! |
Hi @zachwaite, I seem to have fixed the issues in #323 -- would you mind rebasing the PR? |
e4f2719
to
8e65ef1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR! Left a couple of small comments 📝
8e65ef1
to
2992c1d
Compare
This example application is a bare minimum example of the core functionality. Persistence is not enabled, nor is logging, nor any kind of user interface. It just starts, runs some commands, queries the final state and prints it. It models a "light switch". You can "install" the switch, then turn it "off" or "on" using commands. You can issue a query to get the current state of a switch.
2992c1d
to
8ae5395
Compare
Thank you for your contribution once again @zachwaite, may your light switches always work 💡 |
This example application is a bare minimum example of the core functionality. Persistence is not enabled, nor is logging, nor any kind of user interface. It just starts, runs some commands, queries the final state and prints it.
It models a "light switch". You can "install" the switch, then turn it "off" or "on" using commands. You can issue a query to get the current state of a switch.