Invoice Currency Conversion #3379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you share screenshot/video related to changes |
|
you can maybe try to implement it like this at all the places: #3089 |
|
ok I'll create new PR for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
This PR adds a two-way currency conversion feature to the "Make Invoice" screen. You can now enter amounts in either satoshis or your local fiat currency, with the other field updating dynamically based on fetched exchange rates. This enhances flexibility when creating invoices.
Key changes:
MakeInvoice.tsx.SettingsContext.getCurrencyRatefromSettingsContextis exposed and used.Link this PR to an issue [optional]
Fixes #3158
Type of change
feat: New feature (non-breaking change which adds functionality)Checklist