Build on PR #3089 to complete Support fiat input in dual currency field #3388
Conversation
* master: (25 commits) Translated using Weblate (Arabic) Translated using Weblate (German) feat: proper error messages for lndhub Update @getalby/sdk to version 3.6.0 fix: use method to identify connector type fix: show lnaddress only for active account settings feat: use types feat: add http auth kind feat: fix lnaddress setting to show only to alby account feat: extend kind list, kind types, kind translaions fix: remove keys from translations fix: make prompt copy more clear feat: adapt to dynamic width of the container fix: account menu makeover when account name is larger Update i18next to version 23.11.5 Translated using Weblate (Spanish) Translated using Weblate (German) Translated using Weblate (Portuguese (Brazil)) fix: tests fix: unit tests ...
|
Hi team Turns out, the tests were too strict and focused more on the number and order of render-related calls rather than the actual outcome. It's working fine now, though I still plan to reduce re-renders further and optimize the test to test more on actually creating a budge rather than if the getFormattedInCurrency works well.
|
…tch optimized logic
Currently translated at 100.0% (805 of 805 strings) Co-authored-by: BSN ∞/21M ₿ <[email protected]> Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/ Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
Currently translated at 49.8% (401 of 805 strings) Co-authored-by: Claudio Pastorino <[email protected]> Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/es/ Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
migrate to sdkv5
Currently translated at 100.0% (807 of 807 strings) Co-authored-by: BSN ∞/21M ₿ <[email protected]> Translate-URL: https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/ Translation: getAlby - lightning-browser-extension/getAlby - lightning-browser-extension
|
this is totally messed up pr. can you please clear the commit history and make a new clean pr. its hard to review such things |
just to confirm, for the clean PR, would you prefer I base it off the previous contributor’s PR and include only my modifications, or should I start fresh from the main branch and re-implement both their changes and mine? I’m happy to go either way, just want to do what’s easiest for you to review and merge. |
|
Hi, just following up on this.
|
|
whichever is fine. but look at the commit history. it should be clean before the review. only the commits of based of pr and yours. i see lots of noise in this pr |
oh.. alright |
5 participants
🚀 Summary
This pull request continues from where #3089 left off. That initial PR laid the groundwork, and this one builds upon it to complete the implementation and resolve remaining issues.
✨ Changes Introduced
A breakdown of what this PR introduces:
ConfirmPaymentandSitePreferences.Added a default mock implementation for
getFormattedInCurrencyin theSettingsContext. This resolves the failing unit tests inConfirmPayment/index.test.tsxcaused by a missing mock.Work is still in progress for fixing the related test cases.
🔗 Related Issues or PRs
🧩 Type of Change
Select the appropriate type:
fix: Bug fix (non-breaking change which fixes an issue)feat!: Breaking change (may break existing functionality)📸 Screenshots (optional)
Add any relevant screenshots, screen recordings, or UI diffs to help reviewers.
🧪 How This Was Tested
✅ Checklist
For UI-related changes: