Skip to content

Conversation

@pavanjoshi914
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 commented Oct 15, 2025

image

@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review October 17, 2025 10:18
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe try to do an info circle icon next to the kind instead? I don't like the many different font styles on this page already, and let's not make it worse.

@pavanjoshi914
Copy link
Contributor Author

we need to use <0><0></0></0> while nesting. explained here: i18next/react-i18next#928 (comment)

other ways didn't worked for me.

image

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment regarding the translation component. Otherwise this is great! 👍

tACK

@pavanjoshi914 pavanjoshi914 merged commit 0fc8725 into master Nov 4, 2025
7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the kind-description branch November 4, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants