fix(tests): use local-time timestamps in day-aggregator test#160
Closed
gcacace wants to merge 1 commit intogetagentseal:mainfrom
Closed
fix(tests): use local-time timestamps in day-aggregator test#160gcacace wants to merge 1 commit intogetagentseal:mainfrom
gcacace wants to merge 1 commit intogetagentseal:mainfrom
Conversation
The test used 2026-04-09T23:59:00Z (UTC) which falls on April 10th in timezones ahead of UTC, causing dateKey() to return the wrong date. Drop the Z suffix so timestamps are parsed as local time, matching dateKey() which uses getDate() (local). The original midnight-boundary scenario is preserved.
Author
|
Closing as duplicate of #112. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test used 2026-04-09T23:59:00Z (UTC) which falls on April 10th in timezones ahead of UTC, causing dateKey() to return the wrong date.
Drop the Z suffix so timestamps are parsed as local time, matching dateKey() which uses getDate() (local). The original midnight-boundary scenario is preserved.