VSCode: correctly locate workspaceStorage when working inside a dev container#180
Open
josteinaj wants to merge 1 commit intogetagentseal:mainfrom
Open
Conversation
Member
|
Thanks for this! Dev container support is a good catch. One thing: PR #181 (just merged) refactored this function from returning a single path to returning an array of paths. Your PR will have a merge conflict against current main. The good news is the fix becomes even simpler with the new approach. Instead of checking env vars, you can just add the path to the Linux array since return [
join(homedir(), '.config', 'Code', 'User', 'workspaceStorage'),
join(homedir(), '.config', 'Code - Insiders', 'User', 'workspaceStorage'),
join(homedir(), '.vscode-server', 'data', 'User', 'workspaceStorage'),
]Could you rebase on main and update the diff? No env var check needed. |
4b63c67 to
2de8909
Compare
Author
|
Just my luck 😅. I rebased and updated now. Indeed the solution is even simpler and more robust now 👍. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a dev container, the path used is:
In other words, the vscode configuration is stored under
~/.vscode-server/datainstead of~/.config/Code.