ci: Update tox configuration to run Django5 #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgilpin
force-pushed
the
feat/django5
branch
from
b1a16b9 to
dfc947c
Compare
kgilpin
changed the title
Attaching notes on the run, including test errors. We should also see these in CI
kgilpin
force-pushed
the
feat/django5
branch
from
dfc947c to
ca28746
Compare
dividedmind
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaching notes on the run, including test errors.
We should also see these in CI
Fixes #373
Looks like this is still running on Travis -- https://app.travis-ci.com/github/getappmap/appmap-python/builds/273589597
Looks like the build matrix passed with Python >= 3.10. Django 5 is not supported with earlier Pythons, so that is probably why those tests failed. I'm sure Navie can help me figure out how to disable the Django5 tests with those older Pythons.
https://app.travis-ci.com/github/getappmap/appmap-python/builds/273589597