Skip to content

Add support for day period on time-input component #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for day period on time-input component #1282

wants to merge 1 commit into from

Conversation

v-escobar
Copy link
Collaborator

@v-escobar v-escobar commented Oct 17, 2025 •
edited
Loading

Summary

Review Checklist

General

  • Changeset added
  • The submitted code is organized and formatted according to our 💅 Style Guide.
    • The code is formatted with Prettier.
    • There are no linting errors.

For new or updated components

https://swirl-storybook.flip-app.dev/?path=/docs/contributions-merge-publish--page

  • The changes do not contain any breaking changes.
  • The changes do not introduce new components that don't belong in the library (e.g. non-reusable components, highly specialized components, components including business logic)
  • The component documentation is updated.
  • The changes meet the 🤖 testing requirements.
    • New features are tested.
    • In case of bug fixes, regression tests have been added.
    • All tests are 🟢.
  • The changes meet the 🧏‍♀️ accessibility requirements.
    • WCAG 2.1 Level A and Level AA requirements are met.
    • The Storybook a11y addon shows no errors.
    • The changes have been tested with a screen reader.
    • Keyboard controls have been tested, if applicable.
    • Components implementing form controls (inputs, buttons, selects, etc.) do not use Shadow DOM, and instead use Stencil's scoping mechanism
  • The changes use our 🌈 theming concept.
    • Design tokens have been used where appropriate.
    • The component has been visually checked in combination with the "Light" and "Dark" theme.
  • The changes meet our 🌍 internationalization requirements.
    • No static text is used.
    • The component doesn't break with longer texts or different text wrappings.
    • Number, currency and date values can be formatted appropriately.
  • The changes work in all supported browsers and viewports. See 📱 Responsive Design

@v-escobar v-escobar requested a review from Sqrrl as a code owner October 17, 2025 08:32
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://icy-water-049ec4003-1282.westeurope.3.azurestaticapps.net

Sqrrl
Sqrrl reviewed Oct 17, 2025
View reviewed changes
packages/swirl-components/src/components/swirl-time-input/swirl-time-input.tsx
.replace(/(?<!m)m(?!m)/g, "mm")
.replace(/(?<!s)s(?!s)/g, "ss");
.replace(/(?<!s)s(?!s)/g, "ss")
.replace(/(?<!a)a(?!a)/g, "aa"); // Handle single 'a' to 'aa' for AM/PM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Maybe I'm doing it wrong, but doesn't seem to work for me.

Bildschirmaufnahme.2025-10-17.um.10.46.04.mov

packages/swirl-components/src/components/swirl-time-input/swirl-time-input.tsx
},
aa: {
mask: IMask.MaskedEnum,
enum: ["AM", "PM"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Should we also allow "aaa" for "am" and "pm"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sqrrl Sqrrl Sqrrl left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@v-escobar @Sqrrl