Conversation
|
I think there are still some issues to be addressed in the issue for this PR to be considered as fully resolving it. |
Okay, I'll be reading the discussions actively and change the code accordingly. |
|
Please leave this PR as a draft for now |
|
|
||
| jobs: | ||
| linting: | ||
| rust-lint: |
There was a problem hiding this comment.
My understanding of the issue is that this should also be under lint.yml, right @jaoleal?
There was a problem hiding this comment.
renaming the rust job id from linting to rust-lint may break required status checks?
unless branch protection is updated?? am i right?
There was a problem hiding this comment.
My understanding of the issue is that this should also be under
lint.yml, right @jaoleal?
So is it like this, we should move all linting stuff like typos, clippy, cargo fmt, cargo doc, Python lint to lint.yml and rust.yml only for testing and building
There was a problem hiding this comment.
My understanding of the issue is that this should also be under lint.yml, right @jaoleal?
Yes, Ideally a centralized job for linting
|
|
||
| jobs: | ||
| linting: | ||
| rust-lint: |
There was a problem hiding this comment.
My understanding of the issue is that this should also be under lint.yml, right @jaoleal?
Yes, Ideally a centralized job for linting
6 participants
Description and Notes
Closes #677
Currently, typos runs inside the Rust CI linting job in rust.yml, even though it's language agnostic and checks the entire project not just rust code. Similarly, Python linting is duplicated in functional.yml.
This PR creates a dedicated lint.yml workflow that separates language agnostic linting from rust specific check.
How to verify the changes you have done?
the ci passes in my fork https://github.com/psg-19/Floresta/actions
Contributor Checklist
just pcc(recommended but slower)just lint-features '-- -D warnings' && cargo test --release