Repository navigation
fix: littel fixups on floresta-build. - #65
Merged
Merged
Conversation
passthru shadows the overrideAttrs stdenv.mkDerivation provides, and the one defined here called (mkFloresta args).overrideAttrs, which is itself: every overrideAttrs on a Floresta build recursed forever.
floresta-build reads the version off the source's Cargo.toml, so a fetchFromGitHub defaultSrc is import-from-derivation, and `nix flake check ./examples --no-build` cannot build the fetch. It passes only because the main flake check, earlier in the same CI job, instantiates the identical getfloresta fetch; releases fetched from anywhere else break it. builtins.fetchTarball fetches the same tree (same NAR hash, same store path) while evaluating, with no derivation to build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some fixups for floresta-build that enables the next comming PRs.
The first commit fixes a infinite recursion fix because it was reimplementing mkDerivation.
The second commits the src at the evalution time instead only on a derivation time