-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hCaptcha support #562
base: develop
Are you sure you want to change the base?
Add hCaptcha support #562
Conversation
This will add hCaptcha support. - The user only needs to select the provider, set the keys. - This is a drop-in replacement of reCaptcha. PHP code on server side could be optimized. Tested to be working. No error cases were tested.
It would be nice if you take a look at this Pull Request, because it's a very important feature for people like me who want alternatives that are more ethical and respectful of our users than Google. |
@@ -189,10 +197,8 @@ form: | |||
recaptcha.site_key: | |||
type: text | |||
label: PLUGIN_FORM.RECAPTCHA_SITE_KEY | |||
help: PLUGIN_FORM.RECAPTCHA_SITE_KEY_HELP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing these does not seem right to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although hCaptcha is working with this drop-in replacement, there are some additions that seem to make the captcha section less understandable. For instance, hCaptcha is not using the words 'site key' and 'secret key' as a combination, but use 'site key' and 'account key'. Therefore I think it would be better to split the hCaptcha implementation from the original reCaptcha part and provide it to the end user as a standalone section in the Forms plugin configuration.
Hi, is there any major (or minor) todo on this, before it can be merged? |
I posted this code almost 3 years ago as a working drop-in replacement. I think it is still good. I have no intention to make any further changes. If someone feels things should be different, this is up to them to make changes. 😊 hCaptcha has served me well. I am now using Cloudflare (turnstile) for the same purpose (it is way better). It is available directly in the forms plugin. Kind regards. |
This will add hCaptcha support.
👉 PHP code on server side could (should) be optimized.
Tested to be working.
Fixes #423.
Replaces #515.
Kind regards.