Derive ConcreteTag unions/intersections from given component tags#1397
Merged
johnhungerford merged 3 commits intogetkyo:mainfrom Jul 25, 2025
Merged
Derive ConcreteTag unions/intersections from given component tags#1397johnhungerford merged 3 commits intogetkyo:mainfrom
johnhungerford merged 3 commits intogetkyo:mainfrom
Conversation
…ections from givens; added tests
fwbrasil
reviewed
Jul 25, 2025
kyo-data/shared/src/main/scala/kyo/internal/ConcreteTagMacro.scala
Outdated
Show resolved
Hide resolved
fwbrasil
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite for #1393. See discussion.
Problem
The derivation macro for
ConcreteTagcurrently does not search for givenConcreteTaginstances for componentsAandBin composite types likeA | BorA & B. This forces users to require implicit evidence for the full composite type in cases where only one of the types is generic (e.g.,def someMethod[E](A < Abort[E | Closed])(using ConcreteTag[E | Closed]) ...). This creates a more severe problem when one of the types in the intersection isn't known in the type signature, like when one of the types is a dependent type.Solution
Add an implicit search in the
createSinglemethod of theConcreteTagderivation macro to look for a given instance prior to trying to construct it from theTypeRepr.Notes
Also updated some names which hadn't been updated from the previous name
SafeClassTag.